Solana TODOs #15726

yashnevatia · 2024-12-17T09:33:13Z

To run integration tests:

nix develop .
# from root
docker run --name test-db-core -p 5432:5432 -e POSTGRES_PASSWORD=postgres -d postgres
# from root
./core/scripts/setup_testdb.sh
cd ./deployment/ccip/changeset
go test -run TestDeployChainContractsChangeset -v

github-actions · 2024-12-17T10:38:50Z

Flakeguard Summary

Ran new or updated tests between develop and b7429a9 (yn-solana).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestInitialAddChainAppliedTwice	66.67%	false	false	false	3	2	1	0	github.com/smartcontractkit/chainlink/deployment/ccip/changeset	false	3m37.176666666s	@smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions · 2024-12-17T10:39:25Z

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , test-scripts , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (core/scripts) , Core Tests (go_core_fuzz) , GolangCI Lint (.) , Core Tests (go_core_race_tests) , GolangCI Lint (deployment) , lint , SonarQube Scan

1. Missing arguments in call to deployment.NewEnvironment: [Golang Lint (deployment)]

Source of Error:

deployment/environment/crib/ccip_deployer.go:1: : # github.com/smartcontractkit/chainlink/deployment/environment/crib [github.com/smartcontractkit/chainlink/deployment/environment/crib.test]
environment/crib/types.go:37:59: not enough arguments in call to deployment.NewEnvironment
	have (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, "github.com/smartcontractkit/chainlink/deployment".AddressBook, map[uint64]"github.com/smartcontractkit/chainlink/deployment".Chain, []string, nil, func() "context".Context, "github.com/smartcontractkit/chainlink/deployment".OCRSecrets)
	want (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, "github.com/smartcontractkit/chainlink/deployment".AddressBook, map[uint64]"github.com/smartcontractkit/chainlink/deployment".Chain, map[uint64]"github.com/smartcontractkit/chainlink/deployment".SolChain, []string, "github.com/smartcontractkit/chainlink/deployment".OffchainClient, func() "context".Context, "github.com/smartcontractkit/chainlink/deployment".OCRSecrets) (typecheck)

Why: The function deployment.NewEnvironment is being called with fewer arguments than required. The function signature has changed to include additional parameters.

Suggested fix: Update the call to deployment.NewEnvironment to include the missing arguments as per the new function signature.

2. Missing go.sum entries: [Run Tests]

Source of Error:

/home/runner/go/pkg/mod/github.com/ethereum/go-ethereum@v1.14.11/p2p/netutil/net.go:29:2: missing go.sum entry for module providing package golang.org/x/exp/maps (imported by github.com/smartcontractkit/chainlink/v2/core/web); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/web@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
/home/runner/go/pkg/mod/github.com/gorilla/websocket@v1.5.1/client.go:23:2: missing go.sum entry for module providing package golang.org/x/net/proxy (imported by github.com/gorilla/websocket); to add:
	go get github.com/gorilla/websocket@v1.5.1
../chains/evm/assets/units.go:6:2: missing go.sum entry for module providing package golang.org/x/exp/constraints (imported by github.com/smartcontractkit/chainlink/v2/core/chains/evm/assets); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/assets@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
/home/runner/go/pkg/mod/github.com/cockroachdb/pebble@v1.1.2/internal/batchskl/skl.go:67:2: missing go.sum entry for module providing package golang.org/x/exp/rand (imported by github.com/cockroachdb/pebble/internal/batchskl); to add:
	go get github.com/cockroachdb/pebble/internal/batchskl@v1.1.2
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.4.1-0.20241223143929-db7919d60550/pkg/utils/tests/tests.go:8:2: missing go.sum entry for module providing package github.com/stretchr/testify/assert (imported by github.com/smartcontractkit/chainlink/core/scripts/common); to add:
	go get -t github.com/smartcontractkit/chainlink/core/scripts/common
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.4.1-0.20241223143929-db7919d60550/pkg/utils/tests/tests.go:9:2: missing go.sum entry for module providing package github.com/stretchr/testify/require (imported by github.com/smartcontractkit/chainlink/v2/core/web); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/web@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
/home/runner/go/pkg/mod/github.com/gabriel-vasile/mimetype@v1.4.3/internal/charset/charset.go:9:2: missing go.sum entry for module providing package golang.org/x/net/html (imported by github.com/gabriel-vasile/mimetype/internal/charset); to add:
	go get github.com/gabriel-vasile/mimetype/internal/charset@v1.4.3
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.10.0/gin.go:20:2: missing go.sum entry for module providing package golang.org/x/net/http2 (imported by k8s.io/client-go/rest); to add:
	go get k8s.io/client-go/rest@v0.31.1
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.10.0/gin.go:21:2: missing go.sum entry for module providing package golang.org/x/net/http2/h2c (imported by github.com/gin-gonic/gin); to add:
	go get github.com/gin-gonic/gin@v1.10.0
../logger/logger_mocks.go:6:2: missing go.sum entry for module providing package github.com/stretchr/testify/mock (imported by github.com/smartcontractkit/chainlink/v2/core/logger); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/logger@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../gethwrappers/abigen.go:18:2: missing go.sum entry for module providing package golang.org/x/tools/go/ast/astutil (imported by github.com/smartcontractkit/ccip-owner-contracts/pkg/gethwrappers); to add:
	go get github.com/smartcontractkit/ccip-owner-contracts/pkg/gethwrappers@v0.0.0-salt-fix
/home/runner/go/pkg/mod/google.golang.org/grpc@v1.67.1/trace_withtrace.go:26:2: missing go.sum entry for module providing package golang.org/x/net/trace (imported by google.golang.org/grpc); to add:
	go get google.golang.org/grpc@v1.67.1
/home/runner/go/pkg/mod/google.golang.org/grpc@v1.67.1/internal/transport/controlbuf.go:32:2: missing go.sum entry for module providing package golang.org/x/net/http2/hpack (imported by google.golang.org/grpc/internal/transport); to add:
	go get google.golang.org/grpc/internal/transport@v1.67.1
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.4.1-0.20241223143929-db7919d60550/pkg/loop/logger.go:14:2: missing go.sum entry for module providing package golang.org/x/exp/slices (imported by github.com/cosmos/cosmos-sdk/types); to add:
	go get github.com/cosmos/cosmos-sdk/types@v0.47.11
/home/runner/go/pkg/mod/github.com/btcsuite/btcd/btcec/v2@v2.3.2/btcec.go:23:2: missing go.sum entry for module providing package github.com/decred/dcrd/dcrec/secp256k1/v4 (imported by github.com/btcsuite/btcd/btcec/v2); to add:
	go get github.com/btcsuite/btcd/btcec/v2@v2.3.4
/home/runner/go/pkg/mod/github.com/btcsuite/btcd/btcec/v2@v2.3.2/ecdsa/error.go:7:2: missing go.sum entry for module providing package github.com/decred/dcrd/dcrec/secp256k1/v4/ecdsa (imported by github.com/btcsuite/btcd/btcec/v2/ecdsa); to add:
	go get github.com/btcsuite/btcd/btcec/v2/ecdsa@v2.3.4
/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.37.5/abci/types/application.go:4:2: missing go.sum entry for module providing package golang.org/x/net/context (imported by github.com/cometbft/cometbft/abci/types); to add:
	go get github.com/cometbft/cometbft/abci/types@v0.37.5
/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.37.5/p2p/transport.go:9:2: missing go.sum entry for module providing package golang.org/x/net/netutil (imported by github.com/cometbft/cometbft/p2p); to add:
	go get github.com/cometbft/cometbft/p2p@v0.37.5
../services/keystore/keys/solkey/key.go:10:2: missing go.sum entry for module providing package github.com/gagliardetto/solana-go (imported by github.com/smartcontractkit/chainlink/v2/core/cmd); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/cmd@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../services/gateway/handlers/functions/allowlist/allowlist.go:16:2: missing go.sum entry for module providing package golang.org/x/mod/semver (imported by github.com/smartcontractkit/chainlink/v2/core/services/gateway/handlers/functions/allowlist); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/services/gateway/handlers/functions/allowlist@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-solana@v1.1.1-0.20241223151630-eac4f1508dce/pkg/solana/state_cache.go:8:2: missing go.sum entry for module providing package github.com/gagliardetto/binary (imported by github.com/smartcontractkit/chainlink-solana/pkg/solana); to add:
	go get github.com/smartcontractkit/chainlink-solana/pkg/solana@v1.1.1-0.20241223151630-eac4f1508dce
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-solana@v1.1.1-0.20241223151630-eac4f1508dce/pkg/solana/chain.go:16:2: missing go.sum entry for module providing package github.com/gagliardetto/solana-go/programs/system (imported by github.com/smartcontractkit/chainlink-solana/pkg/solana); to add:
	go get github.com/smartcontractkit/chainlink-solana/pkg/solana@v1.1.1-0.20241223151630-eac4f1508dce
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-solana@v1.1.1-0.20241223151630-eac4f1508dce/pkg/solana/chain.go:17:2: missing go.sum entry for module providing package github.com/gagliardetto/solana-go/rpc (imported by github.com/smartcontractkit/chainlink/deployment); to add:
	go get github.com/smartcontractkit/chainlink/deployment@v0.0.0-20241206210521-125d98cdaf66
/home/runner/go/pkg/mod/github.com/!nethermind!eth/starknet.go@v0.7.1-0.20240401080518-34a506f3cfdb/rpc/provider.go:11:2: missing go.sum entry for module providing package golang.org/x/net/publicsuffix (imported by github.com/NethermindEth/starknet.go/rpc); to add:
	go get github.com/NethermindEth/starknet.go/rpc@v0.7.1-0.20240401080518-34a506f3cfdb
../capabilities/ccip/delegate.go:29:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/pkg/consts (imported by github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../capabilities/ccip/delegate.go:30:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/pkg/reader (imported by github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../capabilities/ccip/delegate.go:31:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/pkg/types/ccipocr3 (imported by github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../capabilities/ccip/oraclecreator/plugin.go:34:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/commit (imported by github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../capabilities/ccip/oraclecreator/plugin.go:35:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/commit/merkleroot/rmn (imported by github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../capabilities/ccip/oraclecreator/plugin.go:36:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/execute (imported by github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../capabilities/ccip/oraclecreator/bootstrap.go:32:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/pkg/peergroup (imported by github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
../capabilities/ccip/oraclecreator/plugin.go:40:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/pluginconfig (imported by github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/oraclecreator@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.4.1-0.20241223143929-db7919d60550/pkg/utils/codegen/utils.go:10:2: missing go.sum entry for module providing package golang.org/x/tools/imports (imported by github.com/smartcontractkit/chainlink-common/pkg/utils/codegen); to add:
	go get github.com/smartcontractkit/chainlink-common/pkg/utils/codegen@v0.4.1-0.20241223143929-db7919d60550
../../deployment/solana_chain.go:11:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/chains/solana/utils/common (imported by github.com/smartcontractkit/chainlink/deployment); to add:
	go get github.com/smartcontractkit/chainlink/deployment@v0.0.0-20241206210521-125d98cdaf66
../../deployment/common/changeset/deploy_link_token.go:9:2: missing go.sum entry for module providing package github.com/smartcontractkit/chainlink-ccip/chains/solana/contracts/tests/config (imported by github.com/smartcontractkit/chainlink/deployment/common/changeset); to add:
	go get github.com/smartcontractkit/chainlink/deployment/common/
</cicore>
  
    






<operatoruici>

## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/12599358334) ran successfully :white_check_mark:

[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/12599376273/job/35116125408) , [commit](https://github.com/smartcontractkit/chainlink/commit/0a4e0ccec4bf45d3e0dee4769211482debd2e303)

</operatoruici>

github-actions · 2024-12-18T11:34:44Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

github-actions · 2024-12-18T12:03:18Z

Flakeguard Summary

Ran new or updated tests between develop and 42ed1da (yn-solana).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestInitialAddChainAppliedTwice	66.67%	false	false	false	3	2	1	0	github.com/smartcontractkit/chainlink/deployment/ccip/changeset	false	3m35.683333333s	@smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

jlaveracll · 2024-12-31T16:05:00Z

core/scripts/setup_testdb.sh

@@ -6,7 +6,7 @@ function exit_error {
 }
 # Create a new user and database for development
 # This script is intended to be run on a local development machine
-tdir=$(mktemp -d -t db-dev-user)
+tdir=$(mktemp -d -t db-dev-user-XXXXXX)


FWIW, this worked for me when I ran it outside of nix

…yn-solana

cl-sonarqube-production · 2025-01-03T14:54:32Z

Quality Gate passed

Issues
24 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube

tt-cll · 2025-01-10T15:41:51Z

can we close this?

adding first solana todo

b606a3e

yashnevatia requested review from a team as code owners December 17, 2024 09:33

yashnevatia marked this pull request as draft December 17, 2024 09:33

yashnevatia requested a review from tt-cll December 17, 2024 09:33

yashnevatia added 3 commits December 17, 2024 10:01

adding todos

24ffec9

job spec todo

7376e7d

test TODOs

b7429a9

Adding stuff

42ed1da

yashnevatia and others added 5 commits December 18, 2024 17:28

Adding chainlink-ccip solana pkg

bc536f0

solana draft

79c2961

solana link token skeleton

8a31399

merging

e681a59

stuff

486c512

tt-cll mentioned this pull request Dec 23, 2024

solana link token skeleton #15801

Closed

yashnevatia and others added 8 commits December 23, 2024 17:31

fixing test

c1d11f7

bump go mod; add ccip router

56e7574

solana prereq skeleton

9bd60a8

move deploy code

80561c9

go mod tidy

cdbe726

merging

aa4d2e5

Adding solana link token changeset

c98c36f

adding test for DeployChainContractsSolana

9989bcf

jlaveracll reviewed Dec 31, 2024

View reviewed changes

yashnevatia added 2 commits January 2, 2025 16:35

adding add chain selector

b1a192f

removing test file

8dcd962

tt-cll mentioned this pull request Jan 2, 2025

add support for solana on home chain #15826

Draft

yashnevatia added 2 commits January 3, 2025 11:17

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

b4dc5a6

…yn-solana

adding SetOCR3ConfigSolana

0a4e0cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solana TODOs #15726

Solana TODOs #15726

yashnevatia commented Dec 17, 2024 •

edited by tt-cll

Loading

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 17, 2024 •

edited

Loading

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

jlaveracll Dec 31, 2024

cl-sonarqube-production bot commented Jan 3, 2025

tt-cll commented Jan 10, 2025

Solana TODOs #15726

Are you sure you want to change the base?

Solana TODOs #15726

Conversation

yashnevatia commented Dec 17, 2024 • edited by tt-cll Loading

github-actions bot commented Dec 17, 2024

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

github-actions bot commented Dec 17, 2024 • edited Loading

AER Report: CI Core

1. Missing arguments in call to deployment.NewEnvironment: [Golang Lint (deployment)]

2. Missing go.sum entries: [Run Tests]

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

jlaveracll Dec 31, 2024

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Jan 3, 2025

Quality Gate passed

tt-cll commented Jan 10, 2025

yashnevatia commented Dec 17, 2024 •

edited by tt-cll

Loading

github-actions bot commented Dec 17, 2024 •

edited

Loading